Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Failure to upload video message content will cause the SDK to crash #480

Merged
merged 9 commits into from
Jan 5, 2024

Conversation

withchao
Copy link
Contributor

@withchao withchao commented Jan 5, 2024


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #475

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

withchao and others added 9 commits January 2, 2024 03:47
…turns the connection status (#463)

* entering

* entering

* entering

* entering

* entering

* wasm callback

* wasm callback

* ws
* fix: kicked user invited again into group,the group info do not changed.

Signed-off-by: Gordon <[email protected]>

* fix: wasm parse data.

Signed-off-by: Gordon <[email protected]>

---------

Signed-off-by: Gordon <[email protected]>
…user's info changed. (#468)

* fix: kicked user invited again into group,the group info do not changed.

Signed-off-by: Gordon <[email protected]>

* fix: wasm parse data.

Signed-off-by: Gordon <[email protected]>

* fix: conversation and message's sender info change when notification user's info changed.

Signed-off-by: Gordon <[email protected]>

---------

Signed-off-by: Gordon <[email protected]>
* fix: conversation and message's sender info change when notification user's info changed.

Signed-off-by: Gordon <[email protected]>

* fix: conversation and message's sender info change when notification user's info changed.

Signed-off-by: Gordon <[email protected]>

---------

Signed-off-by: Gordon <[email protected]>
…turns the connection status (#470)

* entering

* entering

* entering

* entering

* entering

* wasm callback

* wasm callback

* ws

* feat: typing

* feat: typing

* feat: typing

* fix: ws js

* fix: ws js
* fix: pull message unread count remove.

Signed-off-by: Gordon <[email protected]>

* BUG: Fix getUpload, fill UploadID and ExpireTime only if dbUpload != nil.

* BUG: Fix sending video message, fill VideoElem.VideoURL only if UploadFile result is not nil.

---------

Signed-off-by: Gordon <[email protected]>
Co-authored-by: Gordon <[email protected]>
(cherry picked from commit af64509)
@withchao withchao requested a review from a team as a code owner January 5, 2024 02:26
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 5, 2024
Copy link

sweep-ai bot commented Jan 5, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@FGadvancer FGadvancer merged commit 404d8ee into openimsdk:release-v3.5 Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants